lkml.org 
[lkml]   [2023]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 1/6] staging: vc04_services: bcm2835-camera: Explicitly set DMA mask
    Date
    In the following patches, vchiq_arm will be migrated to create and use
    its own bus and all the vchiq drivers (bcm2835-camera, bcm2835-audio)
    will be registered to it. Since the platform driver/device model
    internally sets the DMA mask for its registered devices, we would have
    to do it ourself when we remove the platform driver/device registration
    for vchiq devices.

    This patch explicitly sets the DMA mask to bcm2835-camera so as not
    to introduce a regression when we move away from platform
    device/driver model.

    Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
    ---
    .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
    index 346d00df815a..fcad5118f3e8 100644
    --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
    +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
    @@ -1852,6 +1852,12 @@ static int bcm2835_mmal_probe(struct platform_device *pdev)
    unsigned int resolutions[MAX_BCM2835_CAMERAS][2];
    int i;

    + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    + if (ret) {
    + dev_err(&pdev->dev, "dma_set_mask_and_coherent failed: %d\n", ret);
    + return ret;
    + }
    +
    ret = vchiq_mmal_init(&instance);
    if (ret < 0)
    return ret;
    --
    2.40.1
    \
     
     \ /
      Last update: 2023-09-23 16:33    [W:6.075 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site