Messages in this thread | | | Date | Sat, 23 Sep 2023 10:36:10 -0600 | Subject | Re: [PATCH] serial: 8250_pci1xxxx: Annotate struct pci1xxxx_8250 with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/22/23 11:52, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct pci1xxxx_8250. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com> > Cc: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jirislaby@kernel.org> > Cc: linux-serial@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/tty/serial/8250/8250_pci1xxxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_pci1xxxx.c b/drivers/tty/serial/8250/8250_pci1xxxx.c > index a3b25779d921..0da9847f3e91 100644 > --- a/drivers/tty/serial/8250/8250_pci1xxxx.c > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c > @@ -107,7 +107,7 @@ static const int logical_to_physical_port_idx[][MAX_PORTS] = { > struct pci1xxxx_8250 { > unsigned int nr; > void __iomem *membase; > - int line[]; > + int line[] __counted_by(nr); > }; > > static int pci1xxxx_get_num_ports(struct pci_dev *dev)
| |