Messages in this thread Patch in this message | | | Date | Fri, 22 Sep 2023 22:35:09 -0700 | Subject | [PATCH v1 12/18] perf hists browser: Avoid potential NULL dereference | From | Ian Rogers <> |
| |
On other code paths browser->he_selection is NULL checked, add a missing case reported by clang-tidy.
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/ui/browsers/hists.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index f02ee605bbce..f4812b226818 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -3302,7 +3302,7 @@ static int evsel__hists_browse(struct evsel *evsel, int nr_events, const char *h &options[nr_options], &bi->to.ms, bi->to.al_addr); - } else { + } else if (browser->he_selection) { nr_options += add_annotate_opt(browser, &actions[nr_options], &options[nr_options], -- 2.42.0.515.g380fc7ccd1-goog
| |