Messages in this thread | | | Date | Sat, 23 Sep 2023 19:26:03 +0800 | Subject | Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 | From | Jie Luo <> |
| |
On 9/15/2023 12:30 AM, Stephen Boyd wrote: > Quoting Jie Luo (2023-09-12 20:27:25) >> >> >> On 9/13/2023 1:18 AM, Stephen Boyd wrote: >>> Quoting Jie Luo (2023-09-12 05:07:02) >>>> >>>> and freq_tbl are necessary to this clock. >>> >>> I still don't see why the freq_tbl is necessary. >> >> Hi Stephen, >> For clk_rcg2_ops, freq_tbl is used to find the closest rate to decided >> the parent clock, the configuration of clock source and clock divider >> are saved in the freq_tbl to configure the RCG hardware register, the >> mapping of parent clock and hardware register value is decided by the >> freq_tbl for the RCG clock. > > The divider is always 1. The frequency is the frequency of the parent. > The two pieces of information are already known without the frequency > table. Why is it needed?
Hi Stephen, i uploaded the new patchset V9 to remove these redundant freq_tbl by using the clk_ops clk_ops clk_rcg2_mux_closest_ops, thanks for this suggestion for the code improvement.
Best Regards, Jie
| |