Messages in this thread | | | From | Alice Ryhl <> | Date | Fri, 22 Sep 2023 17:29:58 +0200 | Subject | Re: [PATCH 2/2] rust: arc: remove `ArcBorrow` in favour of `WithRef` |
| |
On Thu, Sep 21, 2023 at 11:35 PM Wedson Almeida Filho <wedsonaf@gmail.com> wrote: > > From: Wedson Almeida Filho <walmeida@microsoft.com> > > With GATs, we don't need a separate type to represent a borrowed object > with a refcount, we can just use Rust's regular shared borrowing. In > this case, we use `&WithRef<T>` instead of `ArcBorrow<'_, T>`. > > Co-developed-by: Boqun Feng <boqun.feng@gmail.com> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
I wonder whether "WithArc" is a better name? After all, arc is short for "atomic refcount". I also think it's nice to include Arc in the name of the type.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
| |