lkml.org 
[lkml]   [2023]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect
Date
Gentle Reminder. Please review the commit.

-----Original Message-----
From: Ramya SR (QUIC) <quic_rsr@quicinc.com>
Sent: Friday, September 15, 2023 10:25 AM
To: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Lyude Paul <lyude@redhat.com>; Wayne Lin <Wayne.Lin@amd.com>; Jani Nikula <jani.nikula@intel.com>; Imre Deak <imre.deak@intel.com>; Alex Deucher <alexander.deucher@amd.com>; Jeff Layton <jlayton@kernel.org>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Cc: Ramya SR (QUIC) <quic_rsr@quicinc.com>
Subject: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

Modeset mutex unlock is missing in drm_dp_mst_detect_port function.
This will lead to deadlock if calling the function multiple times in an atomic operation, for example, getting imultiple MST ports status for a DP MST bonding scenario.

Signed-off-by: Ramya SR <quic_rsr@quicinc.com>
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index ed96cfc..d6512c4 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -4154,7 +4154,7 @@ drm_dp_mst_detect_port(struct drm_connector *connector,

ret = drm_modeset_lock(&mgr->base.lock, ctx);
if (ret)
- goto out;
+ goto fail;

ret = connector_status_disconnected;

@@ -4181,6 +4181,8 @@ drm_dp_mst_detect_port(struct drm_connector *connector,
break;
}
out:
+ drm_modeset_unlock(&mgr->base.lock);
+fail:
drm_dp_mst_topology_put_port(port);
return ret;
}
--
2.7.4
\
 
 \ /
  Last update: 2023-09-22 16:29    [W:0.112 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site