lkml.org 
[lkml]   [2023]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] media: i2c: drop check because i2c_unregister_device() is NULL safe
From
Date
Hi Wolfram,

Quoting Wolfram Sang (2023-09-22 09:04:19)
> No need to check the argument of i2c_unregister_device() because the
> function itself does it.

Well spotted!

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only. Please apply to your tree.
>
> drivers/media/i2c/rdacm20.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index f4e2e2f3972a..b4647bda8c21 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -625,8 +625,7 @@ static int rdacm20_probe(struct i2c_client *client)
> v4l2_ctrl_handler_free(&dev->ctrls);
> error:
> media_entity_cleanup(&dev->sd.entity);
> - if (dev->sensor)
> - i2c_unregister_device(dev->sensor);
> + i2c_unregister_device(dev->sensor);
>
> dev_err(&client->dev, "probe failed\n");
>
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2023-09-22 16:29    [W:0.075 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site