Messages in this thread | | | Date | Sat, 2 Sep 2023 12:02:16 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config |
| |
On Fri, Sep 01, 2023 at 12:03:20PM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to > avoid any build failures. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Replied here earlier, but pressed the wrong key & it only went to the list. I think this patch probably also needs to grow a Fixes tag, for commit f2863f30d1b0 ("riscv: errata: Add Andes alternative ports").
The 4 Kconfig patches ideally would've been in a series, since 3 of the 4 seem to be fixes & the 4th depends on one of the fixes being applied.
Thaks, Conor.
> --- > arch/riscv/Kconfig.errata | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata > index bee5d838763b..566bcefeab50 100644 > --- a/arch/riscv/Kconfig.errata > +++ b/arch/riscv/Kconfig.errata > @@ -2,7 +2,7 @@ menu "CPU errata selection" > > config ERRATA_ANDES > bool "Andes AX45MP errata" > - depends on RISCV_ALTERNATIVE > + depends on RISCV_ALTERNATIVE && RISCV_SBI > help > All Andes errata Kconfig depend on this Kconfig. Disabling > this Kconfig will disable all Andes errata. Please say "Y" > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv [unhandled content-type:application/pgp-signature] | |