Messages in this thread Patch in this message | | | Date | Tue, 19 Sep 2023 19:12:24 +0300 | Subject | Re: [PATCH] mtd: spi-nor: atmel: add at25ff321a entry | From | Tudor Ambarus <> |
| |
On 08.09.2023 18:14, nicolas.ferre@microchip.com wrote: > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > Add the at25ff321a 4MB SPI flash which is able to provide > SFDP informations. > Datasheet: https://www.renesas.com/us/en/document/dst/at25ff321a-datasheet > > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > Hi, >
Hi!
> This flash is present on the MikoE flash 10 Click board and was tested on > sama7g5-ek at spi frequency of 80 MHz: > > Here is the test I ran: > root@sama7g5ek-sd:~# dd if=/dev/urandom of=./spi_test bs=1M count=3 > 3+0 records in > 3+0 records out > 3145728 bytes (3.1 MB, 3.0 MiB) copied, 0.932896 s, 3.4 MB/s > root@sama7g5ek-sd:~# mtd_debug write /dev/mtd0 0 3145728 spi_test > Copied 3145728 bytes from spi_test to address 0x00000000 in flash > root@sama7g5ek-sd:~# mtd_debug erase /dev/mtd0 0 3145728 > Erased 3145728 bytes from address 0x00000000 in flash > root@sama7g5ek-sd:~# mtd_debug read /dev/mtd0 0 3145728 spi_read > Copied 3145728 bytes from address 0x00000000 in flash to spi_read > root@sama7g5ek-sd:~# hexdump spi_read > 0000000 ffff ffff ffff ffff ffff ffff ffff ffff > * > 0300000 > root@sama7g5ek-sd:~# mtd_debug write /dev/mtd0 0 3145728 spi_test > Copied 3145728 bytes from spi_test to address 0x00000000 in flash > root@sama7g5ek-sd:~# mtd_debug read /dev/mtd0 0 3145728 spi_read > Copied 3145728 bytes from address 0x00000000 in flash to spi_read > root@sama7g5ek-sd:~# sha1sum spi_test spi_read > 06d5459972d51a2ff4270e612270c6519e797a0b spi_test > 06d5459972d51a2ff4270e612270c6519e797a0b spi_read > > Here are the data from sysfs: > > root@sama7g5ek-sd:~# cat /sys/bus/spi/devices/spi0.0/spi-nor/partname > at25ff321a > root@sama7g5ek-sd:~# cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id > 1f4708 > root@sama7g5ek-sd:~# cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer > atmel > root@sama7g5ek-sd:~# hexdump -C /sys/bus/spi/devices/spi0.0/spi-nor/sfdp > 00000000 53 46 44 50 06 01 00 ff 00 06 01 10 10 00 00 ff |SFDP............| > 00000010 e5 20 e1 ff ff ff ff 01 40 eb 08 6b 08 3b 00 ff |. ......@..k.;..| > 00000020 ee ff ff ff ff ff 00 ff ff ff 00 ff 0c 20 0f 52 |............. .R| > 00000030 10 d8 00 ff 50 2a 2a 01 82 ff 9c d2 64 c1 08 46 |....P**.....d..F| > 00000040 7a 75 7a 75 f7 c4 d5 5c 00 06 51 ff 88 30 00 00 |zuzu...\..Q..0..| > 00000050 > root@sama7g5ek-sd:~# md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp > d540f07cbfb7c9c19654c453b561b311 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp >
Wonderful, thanks Nicolas!
> Best regards, > Nicolas > > drivers/mtd/spi-nor/atmel.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c > index 58968c1e7d2f..c94d52951481 100644 > --- a/drivers/mtd/spi-nor/atmel.c > +++ b/drivers/mtd/spi-nor/atmel.c > @@ -184,6 +184,10 @@ static const struct flash_info atmel_nor_parts[] = { > FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) > NO_SFDP_FLAGS(SECT_4K) > .fixups = &atmel_nor_global_protection_fixups }, > + { "at25ff321a", INFO(0x1f4708, 0, 64 * 1024, 64) > + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) > + PARSE_SFDP > + .fixups = &atmel_nor_global_protection_fixups },
We have recently changed how the flash entries are defined. Would you please try the following changes instead?
diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c index 95f0e139284e..44218716d81e 100644 --- a/drivers/mtd/spi-nor/atmel.c +++ b/drivers/mtd/spi-nor/atmel.c @@ -213,6 +213,12 @@ static const struct flash_info atmel_nor_parts[] = { .flags = SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE, .no_sfdp_flags = SECT_4K, .fixups = &atmel_nor_global_protection_fixups + }, { + .id = SNOR_ID(0x1f, 0x47, 0x08), + .name = "at25ff321a", + .flags = SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE, + .fixups = &atmel_nor_global_protection_fixups + }, { }, { .id = SNOR_ID(0x1f, 0x48, 0x00), .name = "at25df641",
| |