lkml.org 
[lkml]   [2023]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] KVM: X86: Use octal for file permission
From
KVM: x86: (don't capitalize the 'x')

On Tue, Sep 19, 2023, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> Improve code readability and checkpatch warnings:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
> arch/x86/kvm/x86.c | 18 +++++++++---------

If we're going to do this, let's do all of x86/kvm in one patch, i.e. clean up
VMX and SVM too.

I generally don't like checkpatch-initiated cleanups, but I vote to go ahead with
this one. I look at the params just often enough that not having to parse the
#defines would add real value for me.

Any objections?

\
 
 \ /
  Last update: 2023-09-19 17:07    [W:0.029 / U:4.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site