lkml.org 
[lkml]   [2023]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 26/49] media: pci: tw68: Stop direct calls to queue num_buffers field
From
On 14/09/2023 15:33, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> drivers/media/pci/tw68/tw68-video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/pci/tw68/tw68-video.c b/drivers/media/pci/tw68/tw68-video.c
> index 773a18702d36..35296c226019 100644
> --- a/drivers/media/pci/tw68/tw68-video.c
> +++ b/drivers/media/pci/tw68/tw68-video.c
> @@ -360,13 +360,13 @@ static int tw68_queue_setup(struct vb2_queue *q,
> unsigned int sizes[], struct device *alloc_devs[])
> {
> struct tw68_dev *dev = vb2_get_drv_priv(q);
> - unsigned tot_bufs = q->num_buffers + *num_buffers;
> + unsigned tot_bufs = vb2_get_num_buffers(q) + *num_buffers;
> unsigned size = (dev->fmt->depth * dev->width * dev->height) >> 3;
>
> if (tot_bufs < 2)
> tot_bufs = 2;

This check can be dropped since vidq.min_buffers_needed is already set to 2.

> tot_bufs = tw68_buffer_count(size, tot_bufs);
> - *num_buffers = tot_bufs - q->num_buffers;
> + *num_buffers = tot_bufs - vb2_get_num_buffers(q);
> /*
> * We allow create_bufs, but only if the sizeimage is >= as the
> * current sizeimage. The tw68_buffer_count calculation becomes quite

Otherwise this is fine.

Regards,

Hans

\
 
 \ /
  Last update: 2023-09-19 15:58    [W:0.394 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site