Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v3 02/12] regulator: dt-bindings: mt6358: Convert to DT schema | Date | Tue, 19 Sep 2023 07:40:11 -0500 |
| |
On Tue, 19 Sep 2023 18:43:45 +0800, Chen-Yu Tsai wrote: > Convert this from the old style text based binding to the new DT schema > style. This will make adding the MT6366 portion easier. > > The examples have been trimmed down considerably, and the remaining > entries now match what is seen in actual device trees, minus some > properties that aren't covered by the bindings yet, or don't make > sense on their own. > > The original submitter seems to have left MediaTek, so instead the > submitter and maintainer for the MT6366 binding is listed. > > Cc: Zhiyong Tao <zhiyong.tao@mediatek.com> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > Changes since v2: > - Added missing end-of-string match to regulator names > - regulator-coupled-* properties in example dropped > - #include and regulator-allowed-modes moved to new patch > > .../regulator/mediatek,mt6358-regulator.yaml | 97 +++++ > .../bindings/regulator/mt6358-regulator.txt | 350 ------------------ > 2 files changed, 97 insertions(+), 350 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml > delete mode 100644 Documentation/devicetree/bindings/regulator/mt6358-regulator.txt >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml: patternProperties: '^ldo_vxo22$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#]+\\$$'} hint: Fixed strings belong in 'properties', not 'patternProperties' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt6358-regulator.yaml: patternProperties: '^ldo_vusb$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#]+\\$$'} hint: Fixed strings belong in 'properties', not 'patternProperties' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230919104357.3971512-3-wenst@chromium.org
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |