Messages in this thread | | | Date | Tue, 19 Sep 2023 07:21:05 -0500 | Subject | Re: [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander | From | Andrew Davis <> |
| |
On 9/19/23 12:03 AM, Ravi Gunasekaran wrote: > AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus. > The expander at address 0x38 is used to detect daughter cards. > Add a node for this I/O expander. > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > index f5c26e9fba98..035b20386ef3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > @@ -381,6 +381,13 @@ > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pca9554_1: gpio@38 {
As this is at a lower address than the other expander(39), why not put it before that one to keep these in order?
Also, do you need the label(pca9554_1:) for anything, if not drop it for now.
Andrew
> + compatible = "nxp,pca9554"; > + reg = <0x38>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > }; > > &mcu_i2c0 { > > base-commit: dfa449a58323de195773cf928d99db4130702bf7
| |