Messages in this thread | | | Subject | Re: [PATCH v3 13/13] comedi: add HAS_IOPORT dependencies again | From | Niklas Schnelle <> | Date | Tue, 19 Sep 2023 13:40:53 +0200 |
| |
On Wed, 2023-09-13 at 18:07 +0100, Ian Abbott wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > This was previously done in commit b5c75b68b7de ("comedi: add HAS_IOPORT > dependencies"), but that has been reverted because it made it impossible > to select configuration options for several comedi drivers. This is a > do-over that avoids that. > > Since the original patch, modifications have been made to various comedi > modules so that they can still be built even if the port I/O functions > have not been declared, so the configuration options for building those > modules no longer need to depend on HAS_IOPORT. > > Make the COMEDI_ISA_DRIVERS menu option (which allows configuration > options for ISA and PC/104 drivers to be selected) depend on HAS_IOPORT, > and also depend on ISA || ISA_BUS || PC104. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > Co-developed-by: Niklas Schnelle <schnelle@linux.ibm.com> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > Cc: Arnd Bergmann <arnd@kernel.org> > Cc: Niklas Schnelle <schnelle@linux.ibm.com> > Signed-off-by: Ian Abbott <abbotti@mev.co.uk> > --- > v2: N/A. > v3: N/A.
I just gave this another try with the rest of my series including the disablement of the I/O port accessors. I tried both allmodconfig and allyesconfig on s390x and both seem fine. Also definitely see the comedi driver's without HAS_IOPORT dependeny being built.
Thanks, Niklas
| |