Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 19 Sep 2023 11:33:41 +0200 | Subject | Re: [PATCH 1/2] i2c: rcar: introduce Gen4 devices |
| |
Hi Wolfram,
On Wed, Sep 13, 2023 at 10:32 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > So far, we treated Gen4 as Gen3. But we are soon adding FM+ as a Gen4 > specific feature, so prepare the code for the new devtype. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/drivers/i2c/busses/i2c-rcar.c > +++ b/drivers/i2c/busses/i2c-rcar.c > @@ -1070,10 +1071,12 @@ static const struct of_device_id rcar_i2c_dt_ids[] = { > { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 }, > { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 }, > { .compatible = "renesas,i2c-r8a7796", .data = (void *)I2C_RCAR_GEN3 }, > + /* S4 has no FM+ bit */ > + { .compatible = "renesas,i2c-r8a779f0", .data = (void *)I2C_RCAR_GEN3 },
I think the S4 exception belongs in the next patch, adding FM+ support.
> { .compatible = "renesas,rcar-gen1-i2c", .data = (void *)I2C_RCAR_GEN1 }, > { .compatible = "renesas,rcar-gen2-i2c", .data = (void *)I2C_RCAR_GEN2 }, > { .compatible = "renesas,rcar-gen3-i2c", .data = (void *)I2C_RCAR_GEN3 }, > - { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN3 }, > + { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN4 }, > {}, > }; > MODULE_DEVICE_TABLE(of, rcar_i2c_dt_ids);
The rest LGTM.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |