Messages in this thread | | | From | Guo Ren <> | Date | Tue, 19 Sep 2023 17:14:20 +0800 | Subject | Re: [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control |
| |
On Tue, Sep 19, 2023 at 4:47 PM Conor Dooley <conor@kernel.org> wrote: > > Guo, > > On Tue, Sep 19, 2023 at 02:08:32PM +0900, Kwanghoon Son wrote: > > > > > + - const: thead,th1520-reset > > > > > + - const: syscon > > > > > > > > iDumb question perhaps, but why is this a syscon? > > > > > > This is good point. > > > In fact, I took it from the vendor kernel, and I tried to keep it as same as I could. > > > Vendor also followed drivers/reset/reset-imx7.c > > > As Rob said, if don't need it, I'll change it. > > > I have investigated vendor kernels, but it is still not sure reset information. > > I thought this is about sys_reg, but without datasheet, can't tell. > > Therefore, should be stopped patch for a while until knows better comes out. > > Is there documentation in English you can provide to these people that > are trying to add support for your product? Yes, Fuwei would help with this, and thx for all of your work.
> > Thanks, > Conor.
-- Best Regards Guo Ren
| |