Messages in this thread | | | Date | Tue, 19 Sep 2023 10:04:04 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v3 4/6] gpio: vf610: add i.MX8ULP of_device_id entry |
| |
On Mon, Sep 18, 2023 at 04:16:08PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX8ULP GPIO supports similar feature as i.MX7ULP GPIO, but i.MX8ULP is > not compatible with i.MX7ULP per binding doc. i.MX8ULP only has one > register base, not two base.
"per binding doc" is a poor justification IMO, as you literally just changed it earlier in this series. I think the commit message here should re-explain the problem so that the rationale here is clear in isolation.
> Add a new of_device_id entry for i.MX8ULP. But to make the driver could > also support old bindings, check the compatible string first, before > check the device data.
Sweet, seems like you have addressed the backwards compatibility stuff for the old binding :)
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |