Messages in this thread | | | Date | Tue, 19 Sep 2023 12:58:32 +0530 | Subject | Re: [PATCH V2 4/4] arm64: dts: qcom: ipq5018: Add tsens node | From | Sricharan Ramabadhran <> |
| |
On 9/15/2023 6:16 PM, Krzysztof Kozlowski wrote: > On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >> IPQ5018 has tsens V1.0 IP with 4 sensors. >> There is no RPM, so tsens has to be manually enabled. Adding the tsens >> and nvmem node and IPQ5018 has 4 thermal sensors (zones). With the >> critical temperature being 120'C and action is to reboot. Adding all >> the 4 zones here. >> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> [v2] Fixed node names, order and added qfprom cells for points >> seperately to use the calibrate_common and squashed thermal_zone >> nodes here >> >> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 169 ++++++++++++++++++++++++++ >> 1 file changed, 169 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi >> index 9f13d2dcdfd5..d53aea5342e2 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi >> @@ -93,6 +93,117 @@ soc: soc@0 { >> #size-cells = <1>; >> ranges = <0 0 0 0xffffffff>; >> >> + qfprom: qfprom@a0000 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "qcom,ipq5018-qfprom", "qcom,qfprom"; > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. >
oops, moved the compatible to first, but missed it on posting version. Will fix it in V3.
Regards, Sricharan
| |