Messages in this thread | | | Date | Tue, 19 Sep 2023 15:02:34 -0400 | From | Kent Overstreet <> | Subject | Re: [PATCH] bcachefs: Use snprintf() instead of scnprintf() when appropriate |
| |
On Tue, Sep 19, 2023 at 09:17:27AM -0400, Brian Foster wrote: > On Sat, Sep 16, 2023 at 09:30:19AM +0200, Christophe JAILLET wrote: > > snprintf() and scnprintf() are the same, except for the returned value. > > When this value is not used, it is more logical to use snprintf() which is > > slightly simpler. > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > --- > > Seems reasonable: > > Reviewed-by: Brian Foster <bfoster@redhat.com>
No, let's stay with scnprintf as the default - snprintf should be deprecated except for when its return value is actually needed, using it incorrectly has been a source of buffer overruns in the past.
| |