Messages in this thread | | | Date | Mon, 18 Sep 2023 15:41:22 +0200 | Subject | Re: [PATCH v2] platform/x86: thinkpad_acpi: sysfs interface to auxmac | From | Hans de Goede <> |
| |
Hi,
On 9/15/23 18:18, Ilpo Järvinen wrote: > On Fri, 15 Sep 2023, Fernando Eckhardt Valle wrote:
<snip>
>> + goto auxmacinvalid; >> + } >> + >> + if (strncmp(obj->string.pointer + 0x8, "#", 1) != 0 || >> + strncmp(obj->string.pointer + 0x15, "#", 1) != 0) { > > Why use strncmp with (..., 1)? These offsets should defines above and not > use literals.
Right, good point.
To be extra clear here, this should be replaced by != '#' statements, e.g.:
if (obj->string.pointer[AUXMAC_BEGIN_MARKER] != '#' || obj->string.pointer[AUXMAC_END_MARKER] != '#') { ...
Regards,
Hans
| |