lkml.org 
[lkml]   [2023]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] platform/x86: thinkpad_acpi: sysfs interface to auxmac
From
Hi,

On 9/15/23 18:18, Ilpo Järvinen wrote:
> On Fri, 15 Sep 2023, Fernando Eckhardt Valle wrote:

<snip>

>> + goto auxmacinvalid;
>> + }
>> +
>> + if (strncmp(obj->string.pointer + 0x8, "#", 1) != 0 ||
>> + strncmp(obj->string.pointer + 0x15, "#", 1) != 0) {
>
> Why use strncmp with (..., 1)? These offsets should defines above and not
> use literals.

Right, good point.

To be extra clear here, this should be replaced by != '#' statements, e.g.:

if (obj->string.pointer[AUXMAC_BEGIN_MARKER] != '#' ||
obj->string.pointer[AUXMAC_END_MARKER] != '#') {
...

Regards,

Hans

\
 
 \ /
  Last update: 2023-09-18 18:48    [W:0.046 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site