lkml.org 
[lkml]   [2023]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support
Date
Hi Heikki,

Thank you for the feedback.

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Monday, September 18, 2023 1:04 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: Prashant Malani <pmalani@chromium.org>; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org; chrome-platform@lists.linux.dev;
> andriy.shevchenko@linux.intel.com; bleung@chromium.org
> Subject: Re: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport
> Alternatemode 2.1 Support
>
> On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote:
>
> > > > b057250704e8..3a747938cdab 100644
> > > > --- a/include/linux/usb/pd_vdo.h
> > > > +++ b/include/linux/usb/pd_vdo.h
> > > > @@ -376,6 +376,7 @@
> > > > | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 \
> > > > | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
> > > >
> > > > +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7)
> > >
> > > I would suggest putting this header modification in a separate
> > > patch; if for some reason we have to revert the Chrome part of the
> > > change, then we won't rip this part out too (some other driver down
> > > the road may use the macro and would break if it were to be
> > > removed). But I'll leave it to Heikki to determine whether that is preferred.
> > >
> > Heikki, What's your preference here?
>
> I think separate patch for this like Prashant said.

I will add and re-send the removed [PATCH v2 3/5] in the next version.

Sincerely,
Utkarsh Patel.

\
 
 \ /
  Last update: 2023-09-18 18:27    [W:0.059 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site