Messages in this thread | | | Date | Mon, 18 Sep 2023 17:39:56 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature |
| |
On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote: > On 9/18/23 15:57, Andy Shevchenko wrote: > > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote:
...
> >> +static const char * const save_mode_strings[] = { > >> + [TLMI_SAVE_SINGLE] = "single", > >> + [TLMI_SAVE_BULK] = "bulk", > >> + [TLMI_SAVE_SAVE] = "save" > > > > Missing comma. > > Fixing this retro-actively is not really useful, if we > ever need an extra entry we can deal with the churn then.
I agree, but this is to give a comprehensive review as long as I went through the entire change.
> >> +};
-- With Best Regards, Andy Shevchenko
| |