Messages in this thread | | | Date | Mon, 18 Sep 2023 14:06:50 +0100 | From | Mark Brown <> | Subject | Re: [PATCH V3 3/5] ASoC: codecs: Add code for bin parsing compatible with aw87390 |
| |
On Mon, Sep 18, 2023 at 07:52:53PM +0800, wangweidong.a@awinic.com wrote:
> Add aw87390 compatible code to the aw88395_lib.c file > so that it can parse aw87390's bin file > Modify function return value > Remove the fade-enable property because other properties > already implement thi functionality. > Modify the transmission method of parameters.
This would be easier to review if it were split up so that the refactorings are separate commits, removing fade enable is a separate commit and then finally just the changes to add the new CODEC are done. That way each individual commit is both smaller and simpler. [unhandled content-type:application/pgp-signature] | |