Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 18 Sep 2023 14:07:46 +0200 | Subject | Re: [PATCH] arm64: dts: renesas: Apply overlays to base dtbs |
| |
Hi Rob,
On Mon, Sep 11, 2023 at 11:47 PM Rob Herring <robh@kernel.org> wrote: > DT overlays in tree need to be applied to a base DTB to validate they > apply, to run schema checks on them, and to catch any errors at compile > time. > > Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> Looks like some of these apply to multiple base DTs. I've only added them > to 1 base.
Indeed: - draak-ebisu-panel-aa104xd12.dtbo applies to r8a77990-ebisu.dtb, too, - salvator-panel-aa104xd12.dtbo applies to all salvator-x(s) variants.
So should they be added to all bases they apply to?
Or, if you intend none of the composite DTBs to be consumed as-is, but only intend them to be created for validation, perhaps the additional rules should be grouped together at the bottom of the Makefile?
> --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -64,6 +65,8 @@ dtb-$(CONFIG_ARCH_R8A779F0) += r8a779f0-spider.dtb > > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk.dtb > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtbo
Do you still need the individual *.dtbo rules? Perhaps you are afraid that make will auto-delete them as they are only used as intermediaries?
> +r8a779g0-white-hawk-ard-audio-da7212-dtbs := r8a779g0-white-hawk.dtb r8a779g0-white-hawk-ard-audio-da7212.dtbo > +dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtb
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |