Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 18 Sep 2023 10:03:35 +0200 | Subject | Re: [PATCH 10/37] clk: renesas: rzg2l: use core->name for clock name |
| |
On Fri, Sep 15, 2023 at 7:47 AM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: > On 14.09.2023 16:04, Geert Uytterhoeven wrote: > > On Tue, Sep 12, 2023 at 6:52 AM Claudiu <claudiu.beznea@tuxon.dev> wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >> > >> core->name already contains the clock name thus, there is no > >> need to check the GET_SHIFT(core->conf) to decide on it. > >> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > > > Thanks for your patch! > > > >> --- a/drivers/clk/renesas/rzg2l-cpg.c > >> +++ b/drivers/clk/renesas/rzg2l-cpg.c > >> @@ -266,7 +266,7 @@ rzg2l_cpg_sd_mux_clk_register(const struct cpg_core_clk *core, > >> clk_hw_data->priv = priv; > >> clk_hw_data->conf = core->conf; > >> > >> - init.name = GET_SHIFT(core->conf) ? "sd1" : "sd0"; > >> + init.name = core->name; > > > > Note that this does change the case of the names (e.g. "SD0" => "sd0"). > > I guess no one cares... > > As of my experiments and investigation we should be good with it.
Thx, will queue in renesas-clk-for-v6.7.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |