| Date | Mon, 18 Sep 2023 13:09:26 -0700 | Subject | Re: [PATCH net-next 02/19] net: mdio: bcm-iproc: Convert to platform remove callback returning void | From | Florian Fainelli <> |
| |
On 9/18/23 12:50, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian
[unhandled content-type:application/pkcs7-signature] |