Messages in this thread | | | Date | Mon, 18 Sep 2023 08:45:28 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: Remove duplicate worqueue attributes allocation |
| |
On Wed, Sep 06, 2023 at 06:39:04PM +0100, Catalin Marinas wrote: > Commit 84193c07105c ("workqueue: Generalize unbound CPU pods") > inadvertently introduced another call to alloc_workqueue_attrs() > overriding the pointer returned by a previous alloc_workqueue_attrs() a > few lines up in workqueue_init_early(). This leads to a kmemleak report: > > unreferenced object 0xffff000040015000 (size 96): > comm "swapper/0", pid 0, jiffies 4294892296 (age 163.956s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 03 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<000000004cec0d50>] __kmem_cache_alloc_node+0x1c4/0x288 > [<0000000083361c2a>] kmalloc_trace+0x20/0x2c > [<000000005ca61f11>] workqueue_init_early+0xe4/0x538 > [<000000004e6ea358>] start_kernel+0x23c/0x5ec > [<00000000aea9761e>] __primary_switched+0xbc/0xc4 > > Remove the first allocation. > > Fixes: 84193c07105c ("workqueue: Generalize unbound CPU pods") > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> > Cc: Tejun Heo <tj@kernel.org>
Another version of this patch has been applied to wq/for-6.6-fixes.
Thanks.
-- tejun
| |