lkml.org 
[lkml]   [2023]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] spi: imx: take in account bits per word instead of assuming 8-bits
Hi,

On Sun, Sep 17, 2023 at 06:40:37PM +0200, Stefan Moring wrote:
> The IMX spi driver has a hardcoded 8, breaking the driver for word
> lengths other than 8.
>
> Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
> ---

patch subject is missing the 'spi: imx:' prefix. Otherwise:

Reported-by: Sebastian Reichel <sre@kernel.org>
Fixes: 15a6af94a277 ("spi: Increase imx51 ecspi burst length based on transfer length")
Tested-by: Sebastian Reichel <sre@kernel.org>

(no need to Cc stable, since the regression is only in v6.6-rc1)

-- Sebastian

> drivers/spi/spi-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index a8a74c7cb79f..498e35c8db2c 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -662,7 +662,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
> if (spi_imx->count >= 512)
> ctrl |= 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
> else
> - ctrl |= (spi_imx->count*8 - 1)
> + ctrl |= (spi_imx->count * spi_imx->bits_per_word - 1)
> << MX51_ECSPI_CTRL_BL_OFFSET;
> }
>
> --
> 2.42.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-09-17 20:49    [W:0.683 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site