Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [PATCH v1] riscv: dts: allwinner: remove address-cells from intc node | Date | Sun, 17 Sep 2023 16:44:12 +0200 |
| |
Dne sobota, 16. september 2023 ob 11:14:00 CEST je Conor Dooley napisal(a): > From: Conor Dooley <conor.dooley@microchip.com> > > A recent submission [1] from Rob has added additionalProperties: false > to the interrupt-controller child node of RISC-V cpus, highlighting that > the D1 DT has been incorrectly using #address-cells since its > introduction. It has no child nodes, so #address-cells is not needed. > Remove it. > > Fixes: 077e5f4f5528 ("riscv: dts: allwinner: Add the D1/D1s SoC devicetree") > Link: > https://patchwork.kernel.org/project/linux-riscv/patch/20230915201946.41844 > 68-1-robh@kernel.org/ [1] Signed-off-by: Conor Dooley > <conor.dooley@microchip.com> > --- > CC: Rob Herring <robh+dt@kernel.org> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > CC: Conor Dooley <conor+dt@kernel.org> > CC: Chen-Yu Tsai <wens@csie.org> > CC: Jernej Skrabec <jernej.skrabec@gmail.com> > CC: Samuel Holland <samuel@sholland.org> > CC: devicetree@vger.kernel.org > CC: linux-riscv@lists.infradead.org > CC: linux-sunxi@lists.linux.dev > CC: linux-kernel@vger.kernel.org
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards, Jernej
> --- > arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi > b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi index > 8275630af977..b8684312593e 100644 > --- a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi > +++ b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi > @@ -30,7 +30,6 @@ cpu0: cpu@0 { > cpu0_intc: interrupt-controller { > compatible = "riscv,cpu-intc"; > interrupt-controller; > - #address-cells = <0>; > #interrupt-cells = <1>; > }; > };
| |