lkml.org 
[lkml]   [2023]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v2 08/10] dt-bindings: net: dsa: marvell: convert to json-schema
From
On 16.09.2023 17:05, Andrew Lunn wrote:
>> +properties:
>> + compatible:
>> + oneOf:
>> + - description: |
>> + Switch has base address 0x10. Use with models:
>> + 6085, 6095, 6097, 6123, 6131, 6141, 6161, 6165, 6171, 6172, 6175,
>> + 6176, 6185, 6240, 6320, 6321, 6341, 6350, 6351, 6352
>> + const: marvell,mv88e6085
>
> The .txt file contained:
>
> The compatibility string is used only to find an identification
> register, which is at a different MDIO base address in different
> switch families.
>
> Please keep this text. There has been a lot of confusion in the past,
> lots of circular arguments etc, and it is way too late to do anything
> different. So i want to make it clear what the compatible is used for,
> juts to find the ID registers, nothing more.

Will do.

>
>> +
>> + - description: |
>> + Switch has base address 0x00. Use with models:
>> + 6190, 6190X, 6191, 6290, 6361, 6390, 6390X
>
> The .txt file is missing the 6191X and 6393X, which belong here. If
> you need to respin, please could you add them here.

Will do.

Arınç

\
 
 \ /
  Last update: 2023-09-16 17:47    [W:0.060 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site