Messages in this thread | | | Date | Fri, 15 Sep 2023 17:49:34 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map() |
| |
On Fri, Sep 15, 2023, at 17:41, Geert Uytterhoeven wrote: > On Wed, Sep 13, 2023 at 4:30 PM Arnd Bergmann <arnd@arndb.de> wrote: >> On Wed, Sep 13, 2023, at 16:13, Geert Uytterhoeven wrote: >> >> Right, it looks like the GENERIC_IOMAP part if gone from that >> series, and I also see that the PCI host bridge does not actually > > No, 02/30 still enables it.
Ok.
>> map the port I/O window. That's usually fine because very few >> drivers actually need it, and it also means that there should be >> no need for GENERIC_IOMAP or the simpler alternative. >> >> The first version probably only did it accidentally, which is a >> common mistake, and I think the ones for hexagon, m68k, and >> mips can probably be removed as well with some simplifiations. > > When not selecting GENERIC_IOMAP in v2, the build fails with: > > sh4-linux-gnu-ld: lib/devres.o: in function `pcim_iomap_release': > devres.c:(.text+0x234): undefined reference to `pci_iounmap'
Odd, that one is provided based on CONFIG_GENERIC_PCI_IOMAP and should be provided by common code, despite the similar naming this is unrelated to CONFIG_GENERIC_IOMAP.
Arnd
| |