Messages in this thread Patch in this message | | | Date | Fri, 15 Sep 2023 16:37:14 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 5/6] shmem: add file length in shmem_get_folio path |
| |
On Fri, Sep 15, 2023 at 09:51:29AM +0000, Daniel Gomez wrote: > @@ -2251,7 +2252,7 @@ static vm_fault_t shmem_fault(struct vm_fault *vmf) > } > > err = shmem_get_folio_gfp(inode, vmf->pgoff, &folio, SGP_CACHE, > - gfp, vma, vmf, &ret); > + gfp, vma, vmf, &ret, i_size_read(inode));
Surely this should be PAGE_SIZE not i_size?
> @@ -4923,7 +4927,7 @@ struct folio *shmem_read_folio_gfp(struct address_space *mapping, > > BUG_ON(!shmem_mapping(mapping)); > error = shmem_get_folio_gfp(inode, index, &folio, SGP_CACHE, > - gfp, NULL, NULL, NULL); > + gfp, NULL, NULL, NULL, i_size_read(inode));
Same here?
| |