Messages in this thread | | | Date | Fri, 15 Sep 2023 18:46:34 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] hwrng: geode: fix accessing registers |
| |
On Sun, Sep 10, 2023 at 10:34:17AM +0200, Jonas Gorski wrote: > When the membase and pci_dev pointer were moved to a new struct in priv, > the actual membase users were left untouched, and they started reading > out arbitrary memory behind the struct instead of registers. This > unfortunately turned the RNG into a constant number generator, depending > on the content of what was at that offset. > > To fix this, update geode_rng_data_{read,present}() to also get the > membase via amd_geode_priv, and properly read from the right addresses > again. > > Fixes: 9f6ec8dc574e ("hwrng: geode - Fix PCI device refcount leak") > Reported-by: Timur I. Davletshin <timur.davletshin@gmail.com> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217882 > Tested-by: Timur I. Davletshin <timur.davletshin@gmail.com> > Suggested-by: Jo-Philipp Wich <jo@mein.io> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> > --- > drivers/char/hw_random/geode-rng.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |