| Date | Fri, 15 Sep 2023 12:39:59 +0200 | Subject | Re: [PATCH v4 07/42] dt-bindings: power: reset: Add ep93xx reset | From | Krzysztof Kozlowski <> |
| |
On 15/09/2023 10:10, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > Add YAML bindings for ep93xx reset. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > .../bindings/power/reset/cirrus,ep9301-reboot.yaml | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/reset/cirrus,ep9301-reboot.yaml b/Documentation/devicetree/bindings/power/reset/cirrus,ep9301-reboot.yaml > new file mode 100644 > index 000000000000..a5a718dec4b5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/cirrus,ep9301-reboot.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/cirrus,ep9301-reboot.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus EP93xx SoC family reset controller > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + - Nikita Shubin <nikita.shubin@maquefel.me> > + > +properties: > + compatible: > + oneOf: > + - const: cirrus,ep9301-reboot > + - items: > + - enum: > + - cirrus,ep9302-reboot > + - cirrus,ep9307-reboot > + - cirrus,ep9312-reboot > + - cirrus,ep9315-reboot > + - const: cirrus,ep9301-reboot > + > +required: > + - compatible > +
The binding looks fine except... that's not needed. See my comment in next patches.
Best regards, Krzysztof
|