Messages in this thread | | | Date | Fri, 15 Sep 2023 18:05:29 +0800 | Subject | Re: [PATCH wireless-next 7/9] wifi: ath12k: Remove unnecessary (void*) conversions | From | yunchuan <> |
| |
On 2023/9/15 01:06, Jeff Johnson wrote: > On 9/13/2023 9:05 PM, Wu Yunchuan wrote: >> No need cast (void*) to (struct hal_rx_ppdu_end_user_stats *), >> (struct ath12k_rx_desc_info *) or (struct hal_tx_msdu_ext_desc *). >> >> Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> >> --- >> drivers/net/wireless/ath/ath12k/dp_mon.c | 6 ++---- >> drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +- >> drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +- >> 3 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c >> b/drivers/net/wireless/ath/ath12k/dp_mon.c >> index f1e57e98bdc6..41cfe7bd865f 100644 >> --- a/drivers/net/wireless/ath/ath12k/dp_mon.c >> +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c >> @@ -13,8 +13,7 @@ >> static void ath12k_dp_mon_rx_handle_ofdma_info(void *rx_tlv, >> struct hal_rx_user_status *rx_user_status) >> { >> - struct hal_rx_ppdu_end_user_stats *ppdu_end_user = >> - (struct hal_rx_ppdu_end_user_stats *)rx_tlv; >> + struct hal_rx_ppdu_end_user_stats *ppdu_end_user = rx_tlv; >> rx_user_status->ul_ofdma_user_v0_word0 = >> __le32_to_cpu(ppdu_end_user->usr_resp_ref); >> @@ -26,8 +25,7 @@ static void >> ath12k_dp_mon_rx_populate_byte_count(void *rx_tlv, void *ppduinfo, >> struct hal_rx_user_status *rx_user_status) >> { >> - struct hal_rx_ppdu_end_user_stats *ppdu_end_user = >> - (struct hal_rx_ppdu_end_user_stats *)rx_tlv; >> + struct hal_rx_ppdu_end_user_stats *ppdu_end_user = rx_tlv; >> u32 mpdu_ok_byte_count = >> __le32_to_cpu(ppdu_end_user->mpdu_ok_cnt); >> u32 mpdu_err_byte_count = >> __le32_to_cpu(ppdu_end_user->mpdu_err_cnt); > > for both of the above IMO the better solution is to change the > prototype to replace void *rx_tlv with struct > hal_rx_ppdu_end_user_stats *ppdu_end_user and to remove the local > variable > > further, I think you can add const to that since the TLV is only read, > not written > > this better describes that the function requires a specific flavor of > RX TLV rather than handling any RX TLV > Hi,
Sounds like a good idea, I will check other patches for this situation. Thanks for your suggestions.
Wu Yunchuan
| |