Messages in this thread | | | Date | Fri, 15 Sep 2023 11:01:24 +0200 | From | Michael Walle <> | Subject | Re: [PATCH] drm/mediatek: dsi: Fix EOTp generation |
| |
Hi,
Am 2023-09-15 10:58, schrieb AngeloGioacchino Del Regno: > Il 15/09/23 09:57, Michael Walle ha scritto: >> The commit c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register >> definition") inverted the logic of the control bit. Maybe it was >> because >> of the bad naming which was fixed in commit 0f3b68b66a6d ("drm/dsi: >> Add >> _NO_ to MIPI_DSI_* flags disabling features"). In any case, the logic >> wrong and there will be no EOTp on the DSI link by default. Fix it. >> >> Fixes: c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register >> definition") >> Signed-off-by: Michael Walle <mwalle@kernel.org> > > Hello Michael, > your commit is missing a small piece! :-) > > Besides, I've already sent a fix for what you're trying to do here: > https://lore.kernel.org/linux-arm-kernel/07c93d61-c5fd-f074-abb2-73fdaa81fd65@collabora.com/T/
Ahh thanks, didn't noticed this. If not already applied, I'll send a Tested-by: later.
Please disregard this patch then.
-michael
| |