Messages in this thread | | | Date | Fri, 15 Sep 2023 17:46:07 -0700 | Subject | Re: [PATCH v6 23/33] ASoC: dt-bindings: Add Q6USB backend | From | Wesley Cheng <> |
| |
Hi Konrad,
On 9/15/2023 5:37 PM, Konrad Dybcio wrote: > On 16.09.2023 02:10, Wesley Cheng wrote: >> Add a dt-binding to describe the definition of enabling the Q6 USB backend >> device for audio offloading. The node carries information, which is passed >> along to the QC USB SND class driver counterpart. These parameters will be >> utilized during QMI stream enable requests. >> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >> --- >> .../devicetree/bindings/sound/qcom,q6usb.yaml | 55 +++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6usb.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6usb.yaml b/Documentation/devicetree/bindings/sound/qcom,q6usb.yaml >> new file mode 100644 >> index 000000000000..51ff0b1ffa2d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6usb.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/qcom,q6usb-dais.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm ASoC DPCM USB backend DAI >> + >> +maintainers: >> + - Wesley Cheng <quic_wcheng@quicinc.com> >> + >> +description: >> + The USB port is a supported AFE path on the Q6 DSP. This ASoC DPCM >> + backend DAI will communicate the required settings to initialize the >> + XHCI host controller properly for enabling the offloaded audio stream. >> + Parameters defined under this node will carry settings, which will be >> + passed along during the QMI stream enable request and configuration of >> + the XHCI host controller. >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,q6usb >> + >> + iommus: >> + maxItems: 1 >> + >> + "#sound-dai-cells": >> + const: 1 >> + >> + qcom,usb-audio-intr-num: >> + description: >> + Desired XHCI interrupter number to use. Depending on the audio DSP >> + on the platform, it will operate on a specific XHCI interrupter. > So is this the number of interrupters to be used or the index of > a single interrupter? If the latter, then "num" is definitely way > too ambiguous. >
It defines the index of a single interrupter. I'll change the naming of this property.
Thanks Wesley Cheng
| |