Messages in this thread | | | Date | Fri, 15 Sep 2023 14:33:05 -0600 | Subject | Re: [PATCH] wifi: ipw2x00: Annotate struct libipw_txb with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/15/23 14:06, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct libipw_txb. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/net/wireless/intel/ipw2x00/libipw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/ipw2x00/libipw.h b/drivers/net/wireless/intel/ipw2x00/libipw.h > index bec7bc273748..9065ca5b0208 100644 > --- a/drivers/net/wireless/intel/ipw2x00/libipw.h > +++ b/drivers/net/wireless/intel/ipw2x00/libipw.h > @@ -488,7 +488,7 @@ struct libipw_txb { > u8 reserved; > u16 frag_size; > u16 payload_size; > - struct sk_buff *fragments[]; > + struct sk_buff *fragments[] __counted_by(nr_frags); > }; > > /* SWEEP TABLE ENTRIES NUMBER */
| |