Messages in this thread | | | Date | Fri, 15 Sep 2023 14:32:02 -0600 | Subject | Re: [PATCH] dm: Annotate struct stripe_c with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/15/23 14:03, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct stripe_c. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Alasdair Kergon <agk@redhat.com> > Cc: Mike Snitzer <snitzer@kernel.org> > Cc: dm-devel@redhat.com > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/md/dm-stripe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c > index e2854a3cbd28..5e70f5ae394d 100644 > --- a/drivers/md/dm-stripe.c > +++ b/drivers/md/dm-stripe.c > @@ -44,7 +44,7 @@ struct stripe_c { > /* Work struct used for triggering events*/ > struct work_struct trigger_event; > > - struct stripe stripe[]; > + struct stripe stripe[] __counted_by(stripes); > }; > > /*
| |