Messages in this thread | | | Date | Fri, 15 Sep 2023 13:13:20 -0700 | Subject | Re: [PATCH 10/10] platform/x86/intel/ifs: ARRAY BIST for Sierra Forest | From | "Joseph, Jithu" <> |
| |
On 9/15/2023 10:04 AM, Ilpo Järvinen wrote: > On Wed, 13 Sep 2023, Jithu Joseph wrote: >
...
>> diff --git a/drivers/platform/x86/intel/ifs/runtest.c b/drivers/platform/x86/intel/ifs/runtest.c >> index 997d2f07aa0c..9cfd5c015cb2 100644 >> --- a/drivers/platform/x86/intel/ifs/runtest.c >> +++ b/drivers/platform/x86/intel/ifs/runtest.c >> @@ -327,6 +327,38 @@ static void ifs_array_test_core(int cpu, struct device *dev) >> ifsd->status = SCAN_TEST_PASS; >> } >> >> +#define ARRAY_GEN1_TEST_ALL_ARRAYS (0x0ULL) >> +#define ARRAY_GEN1_STATUS_FAIL (0x1ULL) > > Unnecessary parenthesis >
noted
...
>> + >> +static void ifs_array_test_gen1(int cpu, struct device *dev) >> +{ >> + struct ifs_data *ifsd = ifs_get_data(dev); >> + u64 status = 0; > > Just use space instead of tab. >
Will do
Jithu
| |