Messages in this thread | | | Date | Fri, 15 Sep 2023 12:42:37 -0700 | From | Kees Cook <> | Subject | Re: [PATCH][next] tls: Use size_add() in call to struct_size() |
| |
On Fri, Sep 15, 2023 at 01:12:38PM -0600, Gustavo A. R. Silva wrote: > If, for any reason, the open-coded arithmetic causes a wraparound, > the protection that `struct_size()` adds against potential integer > overflows is defeated. Fix this by hardening call to `struct_size()` > with `size_add()`. > > Fixes: b89fec54fd61 ("tls: rx: wrap decrypt params in a struct") > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |