lkml.org 
[lkml]   [2023]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] leds: triggers: gpio: Rewrite to use trigger-sources
On Fri, Sep 15, 2023 at 4:15 PM Rob Herring <robh@kernel.org> wrote:

> > + /*
> > + * The generic property "trigger-sources" is followed,
> > + * and we hope that this is a GPIO.
> > + */
> > + gpio_data->gpiod = fwnode_gpiod_get_index(dev->fwnode,
> > + "trigger-sources",
> > + 0, GPIOD_IN,
> > + "led-trigger");
>
> Isn't this going to look for "trigger-sources-gpio" and
> ""trigger-sources-gpios"?

Indeed. I'll simply code an exception for this into
gpiolib-of.c, it's an OF pecularity after all.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2023-09-15 20:15    [W:1.218 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site