Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 15 Sep 2023 10:04:10 -0700 | Subject | Re: Buggy __free(kfree) usage pattern already in tree |
| |
On Fri, 15 Sept 2023 at 02:56, Alexey Dobriyan <adobriyan@gmail.com> wrote: > > __free() got some usage and some of the usage is buggy:
Yeah, that's sad.
I think the '__free(kfree)' thing should *only* be used in the form
struct obj *p __free(kfree) = kmalloc(...);
which is what our docs mention. Anything else is simply buggy.
But how do we *notice* this?
I do want to stress how I was unhappy about this conversion to begin with
https://lore.kernel.org/lkml/CAHk-=wigZt6kVkY0HU1j_LJ5H1KzwPiYnwwk6CbqXqT=sGenjg@mail.gmail.com/
but I reacted to the wrong issue.
This stuff needs to be done *way* more carefully.
Linus
| |