lkml.org 
[lkml]   [2023]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/platform/uv: Rework NMI "action" modparam handling
On Wed, Sep 13, 2023 at 04:06:51PM -0500, Steve Wahl wrote:
> On Wed, Sep 13, 2023 at 08:01:11PM +0200, Hans de Goede wrote:

> Maybe rework the message so a possible newline doesn't look so
> awkward, by removing the comma?
>
> > + pr_err("UV: Invalid NMI action:%s Valid actions are:\n", val);

It occurred to me overnight that leaving val out completely is an
option, as printing it adds very little value. So a reasonable option
would be:

+ pr_err("UV: Invalid NMI action. Valid actions are:\n");

--> Steve

--
Steve Wahl, Hewlett Packard Enterprise

\
 
 \ /
  Last update: 2023-09-14 17:17    [W:0.068 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site