Messages in this thread | | | From | Jirka Hladky <> | Date | Thu, 14 Sep 2023 15:50:57 +0200 | Subject | Re: [PATCH] perf/x86/amd: Do not WARN on every IRQ |
| |
Thank you, all!
I have confirmed that the latest microcode fixes the issue.
============================================= cat /proc/cpuinfo microcode : 0xaa00212
perf top runs fine, without any kernel warnings =============================================
Jirka
On Thu, Sep 14, 2023 at 2:22 PM Breno Leitao <leitao@debian.org> wrote: > > On Thu, Sep 14, 2023 at 04:52:13PM +0530, Sandipan Das wrote: > > On 9/14/2023 4:48 PM, Peter Zijlstra wrote: > > > On Thu, Sep 14, 2023 at 02:30:43AM -0700, Breno Leitao wrote: > > >> On Thu, Sep 14, 2023 at 11:12:34AM +0200, Peter Zijlstra wrote: > > >>> On Thu, Sep 14, 2023 at 02:25:40PM +0530, Sandipan Das wrote: > > >> > > >>>> I agree with using WARN_ON_ONCE() to make this less intrusive. > > >>> > > >>> Could you send a patch that AMD is happy with? > > >> > > >> Why the current patch is not good enough? > > > > > > Sandipan, can you answer this? I don't tihnk I'm qualified to speak for > > > the AMD pmu and certainly I don't have insight into their design future. > > > > Hi Breno, > > > > Functionally, the patch looks good to me and I will be reusing it > > without any change to the authorship. However, as Peter suggested, I > > wanted to add a message to prompt users to update the microcode and > > also call out the required patch levels in the commit message since > > different Zen 4 variants and steppings use different microcode. > > > > Here's what I plan to send. > > Awesome. Thanks for addressing it. >
-- -Jirka
| |