lkml.org 
[lkml]   [2023]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vfio/pds: Using pci_physfn() to fix a compilation issue
On Mon, Sep 11, 2023 at 08:25:18AM +0000, Tian, Kevin wrote:
> > From: oushixiong <oushixiong@kylinos.cn>
> > Sent: Monday, September 11, 2023 4:08 PM
> >
> > From: Shixiong Ou <oushixiong@kylinos.cn>
> >
> > If PCI_ATS isn't set, then pdev->physfn is not defined.
> > it causes a compilation issue:
> >
> > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no
> > member named ‘physfn’; did you mean ‘is_physfn’?
> > 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> > | ^~~~~~
> >
> > So using pci_physfn() rather than using pdev->physfn directly.
> >
> > Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Yes, we should do both patches

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

\
 
 \ /
  Last update: 2023-09-12 00:09    [W:5.116 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site