Messages in this thread | | | Date | Mon, 11 Sep 2023 10:27:20 +0200 | Subject | Re: [PATCH] dt-bindings: rtc: pcf2123: convert to YAML | From | Javier Carrasco <> |
| |
On 11.09.23 08:17, Krzysztof Kozlowski wrote: > On 10/09/2023 13:00, Javier Carrasco wrote: >> Convert the existing txt binding to the preferred YAML format. >> > >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + spi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + rtc@3 { >> + compatible = "nxp,pcf2123"; >> + reg = <3>; >> + spi-cs-high; > > Example should be complete, so preferably also with interrupts. > > Anyway: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Thank you for the review. You are right, adding a line to complete the example with an interrupt does not cost much. I will add it for v2 and wait a few days in case I should change the maintainer.
Best regards, Javier Carrasco
| |