lkml.org 
[lkml]   [2023]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 07/17] soc: qcom: minidump: Add pending region registration
From
On 09/09/2023 22:16, Mukesh Ojha wrote:
> static int qcom_apss_minidump_probe(struct platform_device *pdev)
> {
> struct minidump_global_toc *mdgtoc;
> @@ -571,7 +688,10 @@ static int qcom_apss_minidump_probe(struct platform_device *pdev)
> return ret;
> }
>
> + mutex_lock(&md_plist.plock);
> platform_set_drvdata(pdev, md);

Why this is locked?

> + qcom_apss_register_pending_regions(md);

Why this one is locked? It seems ordering of your operations is not
correct if you need to lock the providers probe().

> + mutex_unlock(&md_plist.plock);


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-09-11 23:58    [W:0.207 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site