lkml.org 
[lkml]   [2023]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND v3 2/2] selftests/resctrl: Move run_benchmark() to a more fitting file
From
Hi Maciej,

On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote:
> resctrlfs.c file contains mostly functions that interact in some way

This can just be "resctrlfs.c contains ..." (no need for "file")

> with resctrl FS entries while functions inside resctrl_val.c deal with
> measurements and benchmarking.
>
> run_benchmark() is located in resctrlfs.c file even though it's

same here

> purpose is not interacting with the resctrl FS but to execute cache
> checking logic.
>
> Move run_benchmark() to resctrl_val.c just before resctrl_val() that
> makes use of run_benchmark(). Make run_benchmark() static since it's
> not used between multiple files anymore.
>
> Remove return comment from kernel-doc since the function is type void.
>
> Signed-off-by: Wieczor-Retman Maciej <maciej.wieczor-retman@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

\
 
 \ /
  Last update: 2023-09-11 23:52    [W:0.059 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site