Messages in this thread | | | Date | Mon, 11 Sep 2023 19:49:11 +1000 | From | John Watts <> | Subject | Re: [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel |
| |
Hello again,
On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote: > > +maintainers: > > + - John Watts <contact@jookia.org> > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + const: fascontek,fs035vg158 > > + > > + backlight: true > > + port: true > > + power-supply: true > > + reg: true > > + reset-gpios: true > > Why do you need all these 5? They are allowed by panel-common. > > > + > > + spi-3wire: true > > + > > +required: > > + - compatible > > Missing reg. Probably also port. > > > > + - power-supply > > + - reset-gpios > > +
I have just copy pasted the other panel's yaml, so these issues apply there too. Should I fix that panel's yaml up first then re-copy?
> > > Best regards, > Krzysztof >
John.
| |