lkml.org 
[lkml]   [2023]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel
Hello again,

On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote:
> > +maintainers:
> > + - John Watts <contact@jookia.org>
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: fascontek,fs035vg158
> > +
> > + backlight: true
> > + port: true
> > + power-supply: true
> > + reg: true
> > + reset-gpios: true
>
> Why do you need all these 5? They are allowed by panel-common.
>
> > +
> > + spi-3wire: true
> > +
> > +required:
> > + - compatible
>
> Missing reg. Probably also port.
>
>
> > + - power-supply
> > + - reset-gpios
> > +

I have just copy pasted the other panel's yaml, so these issues apply
there too. Should I fix that panel's yaml up first then re-copy?

>
>
> Best regards,
> Krzysztof
>

John.

\
 
 \ /
  Last update: 2023-09-11 23:43    [W:0.134 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site